frankiser profile - python coding challenges

22

First-vnkvstnk 2 1

Very short and clear solution. I especially like the usage of the @property and the super() in the Knight subclass. please-reply@checkio.org schreef op 23/07/2019 2:17: > Hello frankiser, this solution is from "The Warriors" [1] Mission and in "Clear" category. > > 01. class Warrior: > More

15

MarcosRecio

Rotate90, cipher_grille and application to text as char matrix-MarcosRecio 1 1

Good idea how you call rotate90. In cipher I don't understand why you do test count('X') == 1 . I think it could have been enough to keep only 'elif' statement. More

20

Splitter

List comprehensions and zip-Splitter 1 1

Good usage of list comprehensions together with join in the rotate_grill function. More

19

Sebdidier

First-Sebdidier 1

Good idea to do a 2nd find operation within the first find call. More

18

jktujgxtu

First time oop + recursion-jktujgxtu 1 1

Nice recursion in the fight function. Personally I would have used more OOP concepts: e.g. creation of class methods to collect or change the class attributes, using getters and setters. I don't really understand the test 'not count % 2' please-reply@checkio.org schreef op 19/06/2019 1 More

13

yurimelnyk

First-yurimelnyk 1 1

This list comprehension with remainder test is a longer statement then using the step-operator to calculate the sum: array[::2] More

33

kkkkk

Pedantic, use of split, isalpha-kkkkk 1 1

Capitalization could also be done on result with "capitalize()". More

15

syssneck

First-syssneck 1

You could first rotate the list to check the vertical using zip. It is worthwhile to check 'zip' in the manual : rotated_result = zip(*game_result) More

20

Splitter

re.findall-Splitter 1 1

Nice usage of regex to identify a repeating character with rf'{ch}+' More

27

r_tchaik

Simple Counter-r_tchaik 1 1

Good idea to use Counter of the collections library. More

9

chenxia

First-chenxia 1 1

In the range instruction you could have used the step parameter to avoid the IF statement: * class range(start, stop[, step]) Nice usage of try .. except .. to cope with an ampty array. More

10

yukiyanai

First-yukiyanai 1 1

Other alternative to validate that len(set(elements) is 0 or 1 is to use the 'in' operator: len(set(elements) in {0,1} More

11

ksc38317

Clear-ksc38317 1

Shortest solution I saw, but still very readable. The while-loop is a very nice implementation. please-reply@checkio.org schreef op 23/08/2019 18:17: > Hello frankiser, this solution is from "The Warriors" [1] Mission and in "Clear" category. > > 01. class Warrior: > 02. health More

19

Vlad_Lopato

Simple-Vlad_Lopato 1 1

You can also use capitalize() to make first letter of a string a capital letter. More

25

dannedved

sort_array_by_element_frequency-dannedved 1 1

Very nice solution with list of tuples of 3 values. More

17

neshta85

First-neshta85

Very clear solution. Eventually you could make the variable name 'res' a little bit more meaningful as 'word_list', 'resulting_words', .. , but this is definitely only a "nice to have". More

13

Vesagran

First-Vesagran

You can make it shorter by only returning the test <=1. Then you avoid the Truu If .. else False construction: return len(set(elements)) <= 1 More

13

nawow1

clear-nawow1

To populate the dictionary you could have used the get operation with 1 as 'default' parameter get(key[, default]) or in your code: dict.get(letter, 1) With this nice python language structure you can avoid the if .. then .. else .. More

25

vby

clear and easy-vby

Very concise and nice code, with type hints. More

15

ika93

First-ika93

Nice concatenation to come to the correct result More